Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DWN SDK #7

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Update DWN SDK #7

merged 9 commits into from
Sep 26, 2023

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Sep 26, 2023

Updating the DWN SDK to the latest version.

This Includes:

  • encodedData stored within the MessageStore below a certain threshold
  • MessageStore interface now accepts multiple Filters to create OR conditions between filters.
  • 'MessageStore' interface accepts sorting and pagination inputs
  • If sorting by datePublished, add the property published set to true within the filter.

Relevent dwn-sdk-js PRs:
decentralized-identity/dwn-sdk-js#478
decentralized-identity/dwn-sdk-js#456

Copy link
Collaborator

@amika-sq amika-sq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Just a couple of comments from me. Holding final approval until those last dwn-sdk-js changes get in.

src/message-store-sql.ts Show resolved Hide resolved
src/message-store-sql.ts Show resolved Hide resolved
src/message-store-sql.ts Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #7 (63c2b13) into main (857cceb) will increase coverage by 2.97%.
The diff coverage is 96.49%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   77.04%   80.02%   +2.97%     
==========================================
  Files          10       10              
  Lines         806      956     +150     
  Branches      120      140      +20     
==========================================
+ Hits          621      765     +144     
- Misses        185      191       +6     

@LiranCohen
Copy link
Member Author

@amika-sq version was bumped on sdk, ready for final review.

@LiranCohen LiranCohen requested a review from amika-sq September 26, 2023 16:48
package.json Outdated Show resolved Hide resolved
@LiranCohen LiranCohen merged commit efee72a into main Sep 26, 2023
1 check passed
@LiranCohen LiranCohen deleted the lirancohen/update-dwn-sdk branch September 26, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants